virtio-blk: implement DISCARD #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs55
force-pushed
the
virtio-blk-upstream
branch
from
f0b688c to
6d0f4d1
Compare
avsm
reviewed
Mar 5, 2020
| @@ -340,8 +396,16 @@ pci_vtblk_init(struct pci_devinst *pi, char *opts) | |||
|
|
|||
| pthread_mutex_init(&sc->vsc_mtx, NULL); | |||
|
|
|||
| /* Customise the capabilities per-device */ | |||
| vi_consts = (struct virtio_consts*)malloc(sizeof(struct virtio_consts)); | |||
There was a problem hiding this comment.
not testing for malloc failure here?
There was a problem hiding this comment.
Ooh yes good point. I've added and force-pushed a NULL check on the next line ⬇️
There was a problem hiding this comment.
Looks good. There is a calloc a few lines above also unchecked. But that’s unrelated to this PR
djs55
force-pushed
the
virtio-blk-upstream
branch
from
11dae8f to
e90eb74
Compare
The protocol defines DISCARD in v1.1: https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.pdf In this simple implementation we advertise a maximum of 1 segment per request, which fits the backend API `block_delete(_, offset, length)`. Experimentally Linux 5.4.9 seems to send one request at a time (tested by deleting files and then executing `fstrim`) Note we only advertise the feature if the backing file itself supports it. Signed-off-by: David Scott <[email protected]>
djs55
force-pushed
the
virtio-blk-upstream
branch
from
e90eb74 to
de9ab9a
Compare
Signed-off-by: David Scott <[email protected]>
djs55
force-pushed
the
virtio-blk-upstream
branch
from
40d3953 to
63de6b5
Compare
avsm
approved these changes
Mar 8, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol defines DISCARD in v1.1:
https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.pdf
In this simple implementation we advertise a maximum of 1 segment per request, which fits the backend API
block_delete(_, offset, length). Experimentally Linux 5.4.9 seems to send one request at a time (tested by deleting files and then executingfstrim)Note we only advertise the feature if the backing file itself supports it.
Switching from AHCI
virtio-blkworks around the known deadlock in the AHCI implementation #94Signed-off-by: David Scott [email protected]