Correctly return NOERROR even if host resolver returned empty list #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan0dbfe
force-pushed
the
fix/issue-509
branch
4 times, most recently
from
7ea18b6
to
14556e2
Compare
Signed-off-by: dan0dbfe <[email protected]>
dan0dbfe
force-pushed
the
fix/issue-509
branch
from
14556e2
to
427cb6d
Compare
|
The "usual" tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509 and moby/moby#47628.
Dns.resolvenow returns(rr list, unit) resultto distinguish between[]resulting from NOERROR or NXDOMAIN.Dns.getaddrinforeturns(rr list, Msg) resultwith no error handling just like current behaviorMake.answerreturns answers (including[]) if there is no error, otherwise NXDOMAIN is returned.