Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour $PREFIX and $LV2DIR if set #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Honour $PREFIX and $LV2DIR if set #29

wants to merge 2 commits into from

Conversation

hfiguiere
Copy link

@hfiguiere hfiguiere commented Sep 27, 2020 •
edited
Loading

  • also get the CXXFLAGS for lv2 using pkg-config

This is needed to build with a prefix. The default remain the same, but if you do make PREFIX=/some/prefix it will use /some/prefix as a prefix.

Update: also honour $LV2DIR

@hfiguiere
Copy link
Author

I realize that the top-level Makefile set PREFIX to /usr but the inner force it to /usr/local/

@hfiguiere
Honour PREFIX if set
9398c2e 
- also get the CXXFLAGS for lv2 using pkg-config
- make uninstall should work too (setting the top-level prefix
to the same default)
@hfiguiere
Copy link
Author

Updated the patch to fix this and that actually fix make uninstall since the before that it would look for /usr while install does use /usr/local

@hfiguiere hfiguiere changed the title Honour $PREFIX if set Honour $PREFIX and $LV2DIR if set Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hfiguiere