Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new commands #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guysoft
Copy link

@guysoft guysoft commented Jul 25, 2018

Hey,
Not sure you want it, but in zynthian we have a few extra commands we added for our stuff. If you like, you are welcome to PR them bach. work of @jofemodo .
If there is anything you want changed in order to merge also please tell us.
It would make our maintenance easier.

 + list_uris => List current effect instances URIs
 + list_bundles => List current effect instances bundle names
 + preset_list %i => List Presets URIs for a given effect instance ID
 + param_info %i %s => Get range info for a given instance's parameter

Update README.md

     + list_uris => List current effect instances URIs
     + list_bundles => List current effect instances bundle names
     + preset_list %i => List Presets URIs for a given effect instance ID
     + param_info %i %s => Get range info for a given instance's parameter

Update README.md
@guysoft guysoft mentioned this pull request Jul 25, 2018
@guysoft
Copy link
Author

guysoft commented Jul 25, 2018

Trevis build here failed on some stupid wget error:
Would be great if you rebuild, confirm and merge :)

--2018-07-25 10:10:08--  http://mirrors.kernel.org/ubuntu/pool/universe/l/lv2/lv2-examples_1.10.0~dfsg1-1_amd64.deb
Resolving mirrors.kernel.org (mirrors.kernel.org)... 149.20.37.36, 2001:4f8:4:6f:0:1994:3:14
Connecting to mirrors.kernel.org (mirrors.kernel.org)|149.20.37.36|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: http://mirrors.edge.kernel.org/ubuntu/pool/universe/l/lv2/lv2-examples_1.10.0~dfsg1-1_amd64.deb [following]
--2018-07-25 10:10:08--  http://mirrors.edge.kernel.org/ubuntu/pool/universe/l/lv2/lv2-examples_1.10.0~dfsg1-1_amd64.deb
Resolving mirrors.edge.kernel.org (mirrors.edge.kernel.org)... 147.75.69.165, 2604:1380:1000:8100::1
Connecting to mirrors.edge.kernel.org (mirrors.edge.kernel.org)|147.75.69.165|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2018-07-25 10:10:08 ERROR 404: Not Found.

@guysoft
Copy link
Author

guysoft commented Aug 13, 2018

@falkTX Can you at least give a comment if you plan to pull this or not?

@falkTX
Copy link
Member

falkTX commented Aug 13, 2018

I am not associated with MOD anymore. ask @ricardocrudo or perhaps @jkbd

@jkbd
Copy link
Contributor

jkbd commented Aug 13, 2018

I will discuss your pull request with @ricardocrudo next week.

@jkbd
Copy link
Contributor

jkbd commented Aug 21, 2018

@guysoft we decided to not merge your pull request now because we don't seem to be using these features anytime soon and we have other priorities now.

@guysoft
Copy link
Author

guysoft commented Aug 21, 2018

Thanks for your reply. We also in Zynthian moved not to use these features and we are using moddevices/mod-hos/master, so its less urgent for us as well. However we do have a fork of mod-ui and we will probably have a similar PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants