Use getTextColor for retention heatmap cells so text is visible on dark backgrounds #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Jonrosario5 are you able to approve PRs? Or do you have advice on getting PRs merged in this repo? Thanks! |
|
Hi @rgrunberg I don't have access to approve the PR because it is protected and only specific admins can merge into this Repo. But I'll notify our team and will have someone review the merge and approve it. |
|
@Jonrosario5 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retention heatmap cell text is difficult to read on a dark background. This PR:
Before:
After:
