Update LLBC backend for new version of Charon #3807
Conversation
There was a problem hiding this comment.
As discussed offline: split this PR into two (or build upon #3801) to separate the changes required to update the Charon submodule from the ones that add support for traits/generics.
There was a problem hiding this comment.
(Had a bit of a race condition with Zyad reviewing, so there may be some repetition with the comments here.)
As a more high-level comment, it'd be great to write some more thorough documentation for each function so that people unfamiliar with Charon can have a basic intuition for what's going on. Nothing too crazy--just 1/2 sentences above each function would help a lot.
| } | ||
| DefPathData::ValueNs(symbol) => { | ||
| // I think `disambiguator != 0` only with names introduced by macros (though | ||
| // not sure). |
There was a problem hiding this comment.
Should we add a TODO to come back and check?
|
Now that #3801 is merged, please change the title of this PR and its description. |
thanhnguyen-aws
changed the title
I'm not sure the updated title accurately captures what this PR is doing. Are any of the updates needed for the new version of Charon? I thought all such updates were made in #3801. It seems to me that this PR is primarily about adding support for traits? If so, the title and description should capture that. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.