Skip to content

Add NewIOTransport function #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshcarp
Copy link

Adds new NewIOTransport function that returns a Transport.
I needed this because I'm reading/writing to a custom file descriptor.

@jba
Copy link
Contributor

jba commented Jul 11, 2025

We'd probably also want to export the IOTransport type and return that directly, in case we want to add exported fields or methods to it.

This sounds reasonable, but we're going to discuss it internally a bit, as we would with most new API. That may take a couple of weeks due to vacations.

@joshcarp
Copy link
Author

Yeah i noticed this repo isn't returning interfaces, so as a convention it's probably a good idea to make IOTransport public too

@jba jba added the needs investigation status unclear, requires more work and discussion label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation status unclear, requires more work and discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants