mcp: validate required fields in ImageContent and AudioContent #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImageContent and AudioContent now return errors when required fields are missing during JSON marshaling, matching TypeScript schema requirements. ImageContent requires data and mimeType fields. AudioContent requires data and mimeType fields. Added comprehensive test coverage for validation error cases.
This was referenced Jul 4, 2025
findleyr
pushed a commit
that referenced
this pull request
Jul 4, 2025
I noticed this while working on #95. Seems Meta was accidentally skipped in the custom wire format struct.
|
@martinemde I think your suggestion to remove the 'omitempty' attrs is preferable: the missing 'mimeType' or 'data' field is really an error in business logic, not marshalling. For data, we should be careful to replace nil with an empty byte slice, as JSON null is not valid. Thanks for picking this up! |
findleyr
reviewed
Jul 7, 2025
| } | ||
| if c.MIMEType == "" { | ||
| return nil, errors.New("ImageContent missing mimeType") | ||
| } | ||
| return json.Marshal(&wireContent{ |
There was a problem hiding this comment.
As noted, I think we should use an inline type rather than 'wireContent' here, so that we can make Data and MimeType not "omitempty". We should be sure to replace nil data with the empty slice though.
There was a problem hiding this comment.
Thanks, will get to it asap.
jba
requested changes
Jul 14, 2025
| } | ||
| if c.MIMEType == "" { | ||
| return nil, errors.New("ImageContent missing mimeType") | ||
| } | ||
| return json.Marshal(&wireContent{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up related to #91 (though not requiring it).
ImageContentandAudioContentnow return errors when required fields are missing during JSON marshaling, matching TypeScript schema requirements. This follows the pattern in ResourceContents in the same file.ImageContentrequiresdataandmimeTypefields.AudioContentrequiresdataandmimeTypefields.Alternatives:
Another way to go about this would be to not omit required attrs when the values are blank. At least we would produce blank values which is preferable to omitted keys (which cause the typescript sdk client to fail rather than report a tool call malfunction to the user).