-
Notifications
You must be signed in to change notification settings - Fork 588
Rename (Async)HttpRequestCustomizer to Mcp(Async)HttpRequestCustomizer, add delegating implementation #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kehrlann
wants to merge
3
commits into
modelcontextprotocol:main
Choose a base branch
from
Kehrlann:dgarnier/http-request-customizer-polish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
...lcontextprotocol/client/transport/customizer/DelegatingMcpAsyncHttpRequestCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright 2024-2025 the original author or authors. | ||
| */ | ||
| package io.modelcontextprotocol.client.transport.customizer; | ||
|
|
||
| import io.modelcontextprotocol.util.Assert; | ||
| import java.net.URI; | ||
| import java.net.http.HttpRequest; | ||
| import java.util.List; | ||
| import org.reactivestreams.Publisher; | ||
| import reactor.core.publisher.Mono; | ||
|
|
||
| /** | ||
| * Composable {@link McpAsyncHttpRequestCustomizer} that applies multiple customizers, in | ||
| * order. | ||
| * | ||
| * @author Daniel Garnier-Moiroux | ||
| */ | ||
| public class DelegatingMcpAsyncHttpRequestCustomizer implements McpAsyncHttpRequestCustomizer { | ||
|
|
||
| private final List<McpAsyncHttpRequestCustomizer> customizers; | ||
|
|
||
| public DelegatingMcpAsyncHttpRequestCustomizer(List<McpAsyncHttpRequestCustomizer> customizers) { | ||
| Assert.notNull(customizers, "Customizers must not be null"); | ||
| this.customizers = customizers; | ||
| } | ||
|
|
||
| @Override | ||
| public Publisher<HttpRequest.Builder> customize(HttpRequest.Builder builder, String method, URI endpoint, | ||
| String body) { | ||
| var result = Mono.just(builder); | ||
| for (var customizer : this.customizers) { | ||
| result = result.flatMap(b -> Mono.from(customizer.customize(b, method, endpoint, body))); | ||
| } | ||
| return result; | ||
| } | ||
|
|
||
| } | ||
32 changes: 32 additions & 0 deletions
32
...elcontextprotocol/client/transport/customizer/DelegatingMcpSyncHttpRequestCustomizer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2024-2025 the original author or authors. | ||
| */ | ||
|
|
||
| package io.modelcontextprotocol.client.transport.customizer; | ||
|
|
||
| import io.modelcontextprotocol.util.Assert; | ||
| import java.net.URI; | ||
| import java.net.http.HttpRequest; | ||
| import java.util.List; | ||
|
|
||
| /** | ||
| * Composable {@link McpSyncHttpRequestCustomizer} that applies multiple customizers, in | ||
| * order. | ||
| * | ||
| * @author Daniel Garnier-Moiroux | ||
| */ | ||
| public class DelegatingMcpSyncHttpRequestCustomizer implements McpSyncHttpRequestCustomizer { | ||
|
|
||
| private final List<McpSyncHttpRequestCustomizer> delegates; | ||
|
|
||
| public DelegatingMcpSyncHttpRequestCustomizer(List<McpSyncHttpRequestCustomizer> customizers) { | ||
| Assert.notNull(customizers, "Customizers must not be null"); | ||
| this.delegates = customizers; | ||
| } | ||
|
|
||
| @Override | ||
| public void customize(HttpRequest.Builder builder, String method, URI endpoint, String body) { | ||
| this.delegates.forEach(delegate -> delegate.customize(builder, method, endpoint, body)); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of a more efficient way to apply async folding of this. Using
reduceWithoperator would still have to accumulate usingflatMapand would add another operator to the mix, so the loop is fine IMO.