Skip to content

Fix : token_endpoint_auth_signing_alg_values_supported is a json array #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yannj-fr
Copy link

@yannj-fr yannj-fr commented Aug 1, 2025

Motivation and Context

Fixes the OAuthMetadata model validated by Pydantic, token_endpoint_auth_signing_alg_values_supported has to be a list of string, or validation would fail

How Has This Been Tested?

Tested against an Auth0 oauth implementation

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@yannj-fr yannj-fr requested a review from a team as a code owner August 1, 2025 07:53
@yannj-fr yannj-fr requested a review from pcarleton August 1, 2025 07:53
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two others that the type is analogously wrong. Can you fix it?

Also, what are the possible values of it?

@yannj-fr
Copy link
Author

yannj-fr commented Aug 1, 2025

fixed accordingly and updates the possible values.
I have been checking the rest for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants