-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added Support For "Proxy" in SSE and Streamable HTTP Client #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added Support For "Proxy" in SSE and Streamable HTTP Client #1303
Conversation
@felixweinberger Did you get any chance to look at it ?. |
@ihrpr Can you have a look at it please ?. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DebajitKumarPhukan thanks for this contribution!
Could you please elaborate on the motivation for this PR? What are you trying to achieve and is there a concrete use case that you weren't able to address another way?
In general this type of redirect behavior seems like something that should like be handled by applications rather than at the SDK level.
@felixweinberger Thanks for looking into my PR. In major production scenarios with This PR will provide a feature in MCP client to specify proxy configurations which will help the MCP client(s) behind a firewall to be able to securely reach to MCP servers hosted in a remote domain. |
Objective:
Add support for http/https proxy in SSE and Streamable HTTP Client..
Motivation and Context
This is a good to have feature for scenarios where direct reachability to MCP servers is not possible and thus, requires a proxy.
How Has This Been Tested ?
Yes, over a real proxy server to test SSE and Streamable HTTP Client end to end.
Breaking Changes
Proxy is optional and the user may set it or leave it to default which is
None
.Types of changes
Checklist
Related issue number
Closes #1302