Adds meta parameter and method for LLM hidden info #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 18, 2025 01:27
|
@dsp-ant, @LucaButBoring Request you to review this very small change this is my first contribution just exploring the repo as of now. |
src/mcp/client/session.py
Outdated
| @@ -271,17 +271,22 @@ async def call_tool( | |||
| self, | |||
| name: str, | |||
| arguments: dict[str, Any] | None = None, | |||
| meta: dict[str, Any] | None = None, | |||
There was a problem hiding this comment.
Move this to the end for backwards-compatibility — we should have probably added a , *, before, but I'll leave that up to a maintainer to decide if we should start doing that or not (it would also be a breaking change if we started doing that now).
There was a problem hiding this comment.
Done, except the second thing would wait on that for the same
added 2 commits
September 18, 2025 02:31
…28/python-sdk into ishan121028/issue-1224
|
LGTM after changes (I do not have merge permissions, however) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the bug 1224 and implements the parameter and method for the metadata that is passed for cases when the info is to be hidden from LLMs.
Motivation and Context
1224
How Has This Been Tested?
Yes I have tested with
Breaking Changes
Types of changes
Checklist
Additional context