-
Notifications
You must be signed in to change notification settings - Fork 71
Update metaschema URI format in input_schema.rb #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would be helpful to add source code comments explaining what kind of issues on Windows environments the added logic is intended to address. It would also be preferable to add regression tests to |
|
Can you squash your commits into one? |
I'm trying to squash these commits... Couldn't solve the conflict with this merge commit 1272360 using Looking into this. |
cross-compatibility across different OS
Finally could do this. All commits squashed. |
Added a "file://" prefix to prevent the JSON library from not identifying the URI correctly.
Motivation and Context
Fixes #131. The lib wasn't working for STDIO servers on any Windows environment i tested.
How Has This Been Tested?
Tested on Windows and Linux.
(The issue was occuring only on Windows, but i wanted to see if it would break Linux and it didn't.
Breaking Changes
Not expected.
Types of changes
Checklist
Additional context