Fix npx and other processes that launch subprocesses #68
+3
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
previously approved these changes
Nov 26, 2024
jspahrsummers
requested changes
Nov 26, 2024
| // (i.e. via `electron-forge start`) vs a production environment | ||
| // (i.e. YourApp.exe). | ||
| detached: process.platform === "win32" && isElectron(), | ||
| windowsHide: process.platform === "win32" && isElectron(), |
There was a problem hiding this comment.
TIOLI: Should this be an unconditional true now?
There was a problem hiding this comment.
Probably Yes but I wanted to be extra paranoid
anaisbetts
force-pushed
the
ani/fix-npx
branch
from
49944a6
to
9fd52c8
Compare
jspahrsummers
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detached: trueseems to break stdio inheritance for processes, instead try to usewindowsHide. Also, logstderrto the log file