Make included function definitions static

[henrikt-ma]

The purpose is to support generation of one C file per external function. See modelica/ModelicaSpecification#3451 for background.

[HansOlsson]

The purpose is to support generation of one C file per external function. See modelica/ModelicaSpecification#3451 for background.

As far as I understand the outcome of that PR I believe this change isn't needed (but still ok).

[henrikt-ma]

I'd say it is needed because the same function definitions are included in multiple places. For instance,

Modelica-Compliance/ModelicaCompliance/Functions/ExternalObjects/ExternalObjectTable.mo

Line 14 in 856545b

annotation(Include="#include \"ExtObj.c\"");

and

Modelica-Compliance/ModelicaCompliance/Functions/ExternalObjects/ExternalObjectTable.mo

Line 21 in 856545b

annotation(Include="#include \"ExtObj.c\"");

Without the functions being static, this violates this rule:

The Include annotation shall be used in such a way that each external function can be handled in a separate translation unit.

[HansOlsson]

I would say that we need to redesign then.
It doesn't make sense to include three copies of the functions as static variants in the model (apart from being weird it is also fragile).

One solution would be have three different C-files (one per function) and just include the function that is needed at each place. That makes it straightforward to handle each of them in a separate translation unit - and prevents the fragile cross-dependencies.

[henrikt-ma]

I don't mind the approach in #79. I wouldn't go as far as to call the approach with static definitions in a shared file weird, though, as I think it might appeal to some users who prefer to see their implementations side by side, and I can't really see the fragility of it as long as it is used systematically.