Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseModelica prerelease suggestions #3543

Open
olivleno opened this issue Jun 27, 2024 · 6 comments
Open

BaseModelica prerelease suggestions #3543

olivleno opened this issue Jun 27, 2024 · 6 comments
Labels
discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended MCP0031 Base Modelica and MLS modularization (MCP-0031)

Comments

@olivleno
Copy link
Collaborator

Collection and discussion of suggestions from BaseModelica interested.

@olivleno olivleno added the discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended label Jun 27, 2024
@HansOlsson HansOlsson added the MCP0031 Base Modelica and MLS modularization (MCP-0031) label Jun 28, 2024
@HansOlsson
Copy link
Collaborator

From Dassault Systèmes it is mostly Christoff Bürger that will work on it, but one blocking issue I heard (which had been previously discussed) is that the syntax (ignore the semantics at the moment) is close to Modelica without being a strict sub-set.

The closeness makes it tempting to share a parser, but the differences mean that there's then a risk that changes for the Base Modelica parser will negatively impact the Modelica parser. That is a risk that makes prototyping hard to sell internally (even if it "just" impacts the error messages).

@casella
Copy link
Collaborator

casella commented Jun 28, 2024

Do we have a place where all the new syntax constructs are listed?

@henrikt-ma
Copy link
Collaborator

It ended up being @qlambert-pro who took care of setting up our Base Modelica parsing, but from what I've heard the syntax overlap was something that our parser generator was excellent at handling. The main extra cost appears to be the need to fine tune parser error messages for Base Modelica, but as far as I understand we already have a Base Modelica parser without any degradation of error messages for full Modelica. Fine tuning the parser errors for Base Modelica is something we can look into once the grammar is settled.

@henrikt-ma
Copy link
Collaborator

henrikt-ma commented Jun 29, 2024

Generally speaking, I don't think having a single issue to collect prerelease suggestions is going to work. Instead, new issues or pull requests with the MCP0031 label should be opened for each concern. This way, we will be able to have well structured conversations for each suggestion.

Therefore, I suggest that we close this issue before important comments regarding specific suggestions end up here.

@olivleno
Copy link
Collaborator Author

olivleno commented Jul 1, 2024

Therefore, I suggest that we close this issue before important comments regarding specific suggestions end up here.

This was intended as a discussion thread to collect the questions of the newcomers.

I'd suggest to leave it open until our next meeting in September.
For relevant topics new issues with an appropriate title should be opened and linked.

@christoff-buerger
Copy link
Member

christoff-buerger commented Sep 10, 2024

I added a separate ticket about BaseModelica being a subset of Modelica (see #3569). From our perspective, this is an important strategic decision -- we like BaseModelica to be a proper subset of Modelica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended MCP0031 Base Modelica and MLS modularization (MCP-0031)
Projects
None yet
Development

No branches or pull requests

8 participants