Implementation and demo of IntervalTest #3913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
enhancement
AHaumer
requested review from
christiankral,
MartinOtter,
tobolar,
beutlich and
GallLeo
christiankral
approved these changes
Dec 25, 2021
beutlich
reviewed
Dec 28, 2021
| @@ -0,0 +1,3 @@ | |||
| time | |||
| and1.y | |||
| intervallTest.y | |||
There was a problem hiding this comment.
Suggested change
| intervallTest.y | |
| intervalTest.y |
tobolar
reviewed
Jan 10, 2022
| connect(upperLimitInternal, upperLimit); | ||
| connect(lowerLimitInternal, lowerLimit); | ||
| end if; | ||
| assert(upperLimitInternal>lowerLimitInternal, "Erroneous interval limits"); |
There was a problem hiding this comment.
If this assertion is really needed, I would set this as a warning only - insted of hard termination of the simulation. Optionally, a parameter of type "AssertionLevel" could be add to give the user an opportunity to decide - but this approach is not used elsewhere in MSL so maybe not that good idea.
henrikt-ma
reviewed
Jan 10, 2022
Comment on lines
+379
to
+384
| Modelica.Blocks.Interfaces.RealInput lowerLimitInternal annotation (Placement( | ||
| transformation(extent={{-94,-84},{-86,-76}}), iconTransformation(extent={ | ||
| {-94,56},{-86,64}}))); | ||
| Modelica.Blocks.Interfaces.RealInput upperLimitInternal annotation (Placement( | ||
| transformation(extent={{-94,76},{-86,84}}), iconTransformation(extent={{-94,76}, | ||
| {-86,84}}))); |
There was a problem hiding this comment.
Maybe it could be considered good style to at least not have an iconTransformation on a protected component? Maybe remove the entire Placement annotation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Simulink a block IntervalTest (i.e. checking whether the input lies within or without the specified interval) exists, in Modelica you have to implement it again and again using Modelica.Blocks.Logical.{And, Or, GreaterThreshold, GreaterEqualThreshold, LessTreshold, LessEqualThreshold, Greater, GreaterEqual, Less, LessEqual}.
I'm pretty sure that this is a block used in many applications, here is a convenient implementation of this functionality.