Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Gaussian pulse signal source #4017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Jul 31, 2022

When preparing lectures for this fall, I noticed that an important signal source is missing: Gaussian pulse.

@AHaumer AHaumer added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks labels Jul 31, 2022
@AHaumer AHaumer self-assigned this Jul 31, 2022
@dietmarw dietmarw removed their request for review September 5, 2022 12:59
@beutlich beutlich removed their request for review September 24, 2022 10:20
@christiankral
Copy link
Contributor

OK, as I have no actual application of a Gaussian pulse source, so I just want to summarize and clarify its behavior:

  • There is the option to create a sequence of pulses using the parameter nperiod
  • The pulses are not superimposed. Instead a strictly periodic signal with no overlap of the individual pulses is created.
  • So the behavior is different from creating a vector of single pulse sources with consecutive startTime and adding their outputs.

@AHaumer I suppose this behavior is intended, isn't it?

parameter SI.Time startTime=0.5 "Time instant of pulse maximum";
protected
SI.Time t0(start=startTime, fixed=true);
initial equation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants