Math asserts #4344
Merged
Math asserts #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hubertus65
approved these changes
Mar 1, 2024
|
It seems #4338 is seen as blocking for 4.1.0 release; thus this is needed. |
3 tasks
|
We can merge this on master anyway, I guess. |
Yes. It just seems that CI-checks didn't complete. |
|
@casella Should this be backported to maint/4.1.x? |
|
Please do, this is necessary for proper regression testing. Thanks! |
Esther-Devakirubai
pushed a commit
that referenced
this pull request
Sep 30, 2024
* AddAssertsForDiff * AddAssertForIntegration
Merged
|
Backported to maint/4.1.x by #4470 |
casella
pushed a commit
that referenced
this pull request
Oct 24, 2024
* AddAssertsForDiff * AddAssertForIntegration Co-authored-by: Hans Olsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertions in example-functions so that we will detect if they fail.
Related to #4338 - but I don't see it as needed for release.