Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nthRoot as proposed for Modelica 3.7. #4392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 19, 2024

  1. Use nthRoot as proposed for Modelica 3.7.

    Note that there are some other uses that were deliberately not updated here:
    - Modelica.Fluid.Dissipation.HeatTransfer.General.kc_approxForcedConvection_KC
    - Modelica.Fluid.Dissipation.HeatTransfer.Channel.kc_evenGapLaminar_KC
    - Modelica.Fluid.Dissipation.HeatTransfer.HelicalPipe.kc_laminar_KC
    - Modelica.Fluid.Dissipation.HeatTransfer.Plate.kc_laminar_KC
    - Modelica.Fluid.Pipes.BaseClasses.HeatTransfer.LocalPipeFlowHeatTransfer
    - Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung
    - Modelica.Fluid.Dissipation.Utilities.Functions.PressureLoss.TwoPhase.SlipRatio
    
    However, if done it must be after switching to sqrt.
    
    I believe Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung should be updated, but I don't know about the rest.
    However, the units seems to be weird in that one (Ångström?) so I'm not proposing it.
    
    Note that many of them use dimensionless numbers and thus there is no unit-issue.
    There are also other rational exponents, I'm even less sure about them.
    HansOlsson committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    288d37c View commit details
    Browse the repository at this point in the history