Skip to content

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Sep 12, 2025

enhances the mentioned example to avoid problems
changes the comparisonSignals (old ones are bad - see discussion in #4688)
@uschna pls. test
@GallLeo @MatthiasBSchaefer pls. prodice new reference result - thx!
@casella should we backport to 4.1.1? I suppose "no".

changes the comparisonSignals (old ones are bad - see discussion in modelica#4688)
@AHaumer AHaumer added this to the MSL4.2.0 milestone Sep 12, 2025
@AHaumer AHaumer self-assigned this Sep 12, 2025
@AHaumer AHaumer added bug Critical/severe issue L: Electrical.Machines Issue addresses Modelica.Electrical.Machines example Issue only addresses example(s) create new reference results create new reference results labels Sep 12, 2025
@AHaumer AHaumer enabled auto-merge September 12, 2025 15:57
@AHaumer AHaumer disabled auto-merge September 12, 2025 15:57
@AHaumer AHaumer marked this pull request as draft September 15, 2025 09:53
@AHaumer
Copy link
Contributor Author

AHaumer commented Sep 15, 2025

Sorry @uschna I have to check in detail today's evening.

@uschna
Copy link

uschna commented Sep 15, 2025

Dear @AHaumer,
thank you for your correction. I see only few differences now, for example:

  1. Placement-annotation of constantVoltage
  2. shorter Types ((Modelica.Electrical.)Analog.Sources.ConstantVoltage, (Modelica.)Blocks.Sources.BooleanConstant, and (Modelica.Electrical.)Analog.Ideal.IdealOpeningSwitch)
  3. other initial equations: idq_ss and idq_rs instead of idq_sr and idq_rr

Hence, I must test it again.

@AHaumer AHaumer marked this pull request as ready for review September 15, 2025 15:47
@AHaumer
Copy link
Contributor Author

AHaumer commented Sep 15, 2025

Thanks for looking into details, @uschna
Somehow I mixed up the old and the new version.
Should be corrected now.

@uschna
Copy link

uschna commented Sep 15, 2025

Dear @AHaumer,
I tested it again with this version and your results. It is also valid. Thank you.

@casella
Copy link
Contributor

casella commented Sep 16, 2025

@casella should we backport to 4.1.1? I suppose "no".

I would keep 4.1.1 for critical fixes, e.g. if we discover late that we introduced regressions in 4.1.0.

@christiankral
Copy link
Contributor

Instead of comparing stator and rotor current components, we could for example compare the magnitudes of the current phasor components. In case of the stator current this is equivalent to the quasi rms current of the phase currents sensed by Polyphase.Sensors.CurrentQuasiRMSSensor:

image

@AHaumer
Copy link
Contributor Author

AHaumer commented Sep 22, 2025

Instead of comparing stator and rotor current components, we could for example compare the magnitudes of the current phasor components. In case of the stator current this is equivalent to the quasi rms current of the phase currents sensed by Polyphase.Sensors.CurrentQuasiRMSSensor:

Why not comparing the current phasor components, from which you are able to compute torque?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue create new reference results create new reference results example Issue only addresses example(s) L: Electrical.Machines Issue addresses Modelica.Electrical.Machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants