Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial FlexRay section for fmi-ls-bus #161

Merged
merged 63 commits into from
Oct 22, 2024
Merged

Conversation

bmenne-dspace
Copy link
Contributor

@bmenne-dspace bmenne-dspace commented May 13, 2024

This PullRequest contains the initial version of the FlexRay section within the fmi-ls-bus. In detail it contains the initial complete context of the specification, operations and corresponding header files.

@bmenne-dspace bmenne-dspace modified the milestones: future, 1.1.0-alpha May 17, 2024
@bmenne-dspace bmenne-dspace linked an issue May 24, 2024 that may be closed by this pull request
@bmenne-dspace bmenne-dspace marked this pull request as ready for review September 27, 2024 13:20
@snps-ribbe
Copy link
Contributor

I approve the current initial version to be merged. Keeping it open for the subsequent design meeting.

Copy link
Contributor

@snps-ribbe snps-ribbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Copy link

@kahramonj kahramonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! I reviewed some files sketchy and put comments on very minor things.

docs/4_4_3_flexray.adoc Show resolved Hide resolved
headers/fmi3LsBusFlexRay.h Show resolved Hide resolved
headers/fmi3LsBusUtilFlexRay.h Show resolved Hide resolved
docs/2____common_concepts.adoc Outdated Show resolved Hide resolved
docs/4_4_3_flexray.adoc Outdated Show resolved Hide resolved
Copy link

@TPfitzer TPfitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also approve this as a initial Version.

@chrbertsch
Copy link
Collaborator

chrbertsch commented Oct 22, 2024

FMI-Design-Meeting:
Let's merge after some typo fixes.
We will vote on alpha stage in next weeks steering committee.

@bmenne-dspace bmenne-dspace merged commit 9798b57 into main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flexray Issue related to FlexRay bus
Projects
None yet
6 participants