Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify valid combinations for containsXcpService and supportsExternalXcpService #15

Closed
pmai opened this issue May 9, 2023 · 4 comments · Fixed by #34
Closed

Clarify valid combinations for containsXcpService and supportsExternalXcpService #15

pmai opened this issue May 9, 2023 · 4 comments · Fixed by #34
Assignees

Comments

@pmai
Copy link
Collaborator

pmai commented May 9, 2023

The way that the spec is currently phrased would allow both containsXcpService and supportsExternalXcpService to be true, which is intended, but it would also allow both to be false, which I am not sure is intentional, nor what the semantic meaning of this would be.

If at least one of the two flags must be true, then the spec should say so, otherwise the spec should spell out what the meaning of both of them being false would be.

@PTaeuberDS
Copy link
Collaborator

In Section 5 "External XCP Service" this is written as non-normative text:
"Note that the FMU must set at least one of the attributes containsXcpService or supportsExternalXcpService to true to make use of this layered standard."
This implies that it is not forbidden but would make this LS useless.
Is this sufficient or shall we forbid it explicitly in normative text in a more central place in the document?

@PTaeuberDS
Copy link
Collaborator

FMI Design Meeting Paderborn:

(How) should we rename the 1st attribute to:

  1. No renaming
  2. ContainsInternalXcpService -> ContainsXcpService
  3. ContainsInternalXcpService -> ProvidesXcpService

1: 5
2: 7
3: 6
Abstain: 2

Should we rename the 2nd attribute to:
2) SupportsExternalXcpService -> SupportsDirectMemoryAccessViaA2L

Yes: 14
No: 1
Abstain: 2

PTaeuberDS added a commit to PTaeuberDS/fmi-ls-xcp that referenced this issue Jun 12, 2023
@PTaeuberDS
Copy link
Collaborator

Addressed in #26/#27, respectively.

@PTaeuberDS PTaeuberDS assigned PTaeuberDS and unassigned pmai Jun 16, 2023
@PTaeuberDS
Copy link
Collaborator

We should change the non-normative recommendation for valid combinations of containsXcpService and supportsDirectMemoryAccessViaA2L to normative text and mandate that not both of them must be false.

I will do this in a following PR.

PTaeuberDS added a commit to PTaeuberDS/fmi-ls-xcp that referenced this issue Aug 30, 2023
PTaeuberDS added a commit to PTaeuberDS/fmi-ls-xcp that referenced this issue Aug 31, 2023
@chrbertsch chrbertsch linked a pull request Aug 31, 2023 that will close this issue
PTaeuberDS added a commit that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants