Alt. 1: Duplicated IpAddress and Port variables for both protocols #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tMemoryAccessViaA2L (Issue modelica#15)
…nd distinguish TCP/UDP (Issue modelica#14 and modelica#19)
PTaeuberDS
changed the title
This was referenced Jun 16, 2023
|
@andreas-junghanns @pmai The PR is ready for review. Due to the open discussion in #19 there are two variants of this PR now (see PR description). |
andreas-junghanns
approved these changes
Jun 16, 2023
PTaeuberDS
changed the title
|
@andreas-junghanns I merged your review PR from main into this PR. Can we also merge this one and make this the new baseline? Then we can decide with the other PR if we want to go for the other alternative afterwards. |
andreas-junghanns
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Big step forward. I think "FMI 2" and "FMI 3" should be replaced with "FMI 2.0" and "FMI 3.0" as this is what we use elsewhere. I know you mean FMI 2.X, which is technically more correct, but it looks strange if this is the only FMI standard text (is it?) that uses these. Can be fixed later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #27 but without one commit that is added to #27 and adds another configuration parameter for the protocol.
In this PR (#26) the IpAddress and port variables are duplicated for the different protocol types for the special case that an XCP service uses TCP and UDP channels in parallel.