Additional protocol variable and no duplication of IpAddress and Port variables #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
|
@andreas-junghanns @pmai The PR is ready for review. See discussion in #19. |
PTaeuberDS
force-pushed
the
resolveIssues_oneProtocolVar
branch
from
5d9fb09
to
8660eee
Compare
andreas-junghanns
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
I like this version somewhat better as this is how I have seen it done in many tools.
However, as @pmai points out: the a2l file is more powerful and we cannot be consistent with it in all cases. At best, we should not contradict the a2l specification. I wish I had a good intuition about what to do here.
PTaeuberDS
changed the title
PTaeuberDS
force-pushed
the
resolveIssues_oneProtocolVar
branch
from
8660eee
to
ae24da6
Compare
PTaeuberDS
force-pushed
the
resolveIssues_oneProtocolVar
branch
from
ae24da6
to
b849eeb
Compare
PTaeuberDS
changed the title
|
After some more digging into this topic I'm now convinced that the current version that allows running two channels in parallel should be the preferred way. Therefore, I close this PR. I will add some more comments in the issue (#19). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the duplication of the IpAddress and port variables for the different protocols, but adds another variable to configure the protocol.