Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fmi3Version to "3.0.1" in fmi3Functions.h #1913

Closed
wants to merge 1 commit into from

Conversation

t-sommer
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@chrbertsch chrbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. So we missed this in the FMI 3.0.1 release.
But when we have a new release, it will be 3.0.2, so shouldn't we change this accordingly already?
And 2.2.5 still states "The standard header file as documented in this specification has version 3.0, so this function returns 3.0." and should also be changed.

@pmai
Copy link
Collaborator

pmai commented Nov 23, 2023

Should this change at all? The standard states:

Patch versions will only change explanatory text of the standard, make formerly defined content clearer, without any other changes to the XML schemas or other content definitions. For this reason, the version number attribute of all FMI files will only contain major and minor version numbers and not the patch version number: It should never be necessary for an importer to know the patch version number of the standard that the generating tool implemented.

Given this rationale, that the XML attribute is supposed to say 3.0 for 3.0.1, and that 3.0.1 did not change the version in the header, I think this ship has sailed and fmi3Version as well as fmi3GetVersion should likewise only report the major.minor version...

@t-sommer t-sommer closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants