Remove Impact workflow from CI #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since repo has been archived
|
I dont think you should have removed the listing of the libraries. Its only
the impact search page and impact tool that is archived. The listing on
modelica.org is completely i dependent. The 3rd party repositories continue
to exist. So you really should role the merge of this u reviewed pr back
again.
ons. 14. feb. 2024, 17:20 skrev Torsten Sommer ***@***.***>:
… Merged #67 <#67> into
main.
—
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACI5HHW7TI7TAUJE26UP3YTTP3HAVCNFSM6AAAAABDISGK6WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAYDIMJVGAYDGMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
We just discussed this in the MA Board Meeting and decided to move this to modelica.org website (see also #66). |
|
It is already in the modelica website. See also my comment on #66. Again nothing to do with impact. So really you should not remove the listing until you have a newer one which is working. |
|
So please role this PR back until #66 is resolved with an updated view if you want. Also It is strange that PRs are merged without any review for something so visible to the outside world like the website. @hubertus65 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since repository has been archived