Add support for deepseek #534
Open
+407
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavdGao
reviewed
Feb 17, 2025
| ) | ||
|
|
||
| # from agentscope.agents import DialogAgent |
There was a problem hiding this comment.
Remove unnecessary changes.
| @@ -56,7 +56,14 @@ def log_stream_msg(msg: Msg, last: bool = True) -> None: | |||
|
|
|||
| # Print msg to terminal | |||
| formatted_str = msg.formatted_str(colored=True) | |||
|
|
|||
|
|
|||
| # Debug prefix tracking | |||
| @@ -48,3 +48,61 @@ def _verify_text_content_in_openai_message_response(response: dict) -> bool: | |||
| return False | |||
|
|
|||
| return True | |||
|
|
|||
|
|
|||
| def _verify_reasoning_content_in_openai_message_response( | |||
There was a problem hiding this comment.
openai or deepseek or both?
| def __init__( | ||
| self, | ||
| config_name: str, | ||
| model_name: Optional[str] = None, |
There was a problem hiding this comment.
model_name is a required parameter
| # then the model name is deepseek-r1 and deepseek-v3 | ||
|
|
||
| # supported_models: list[str] = [ | ||
| # "deepseek-chat", |
There was a problem hiding this comment.
Since we don't hope developers to modify this file, it's suggested to add deepseek-r1 and deepseek-v3 into the supported models.
| generate_args: Optional[dict] = None, | ||
| **kwargs: Any, | ||
| ) -> None: | ||
| """Initalize the openai client. |
There was a problem hiding this comment.
Change the docstrings for deepseek.
| if usage is not None: | ||
| self.monitor.update_text_and_embedding_tokens( | ||
| model_name=self.model_name, | ||
| prompt_tokens=usage.get("prompt_tokens", 0), |
There was a problem hiding this comment.
What about reasoning tokens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deepseek official api
Description
This PR adds support for the Deepseek API. Since Deepseek uses an OpenAI-compatible API, the wrapper is almost the same as the OpenAI one. The key difference lies in the yield generator, which now needs to access both the
contentandreasoning_contentfields from the response.issues
The Deepseek official URL is often unresponsive. For testing and debugging, use the Aliyun-hosted version as a fallback.
The streaming handling in logging.py causes bugs when displaying flags to indicate whether reasoning and final answer generation have started. Consider a better implementation.
Streaming content can be a bit chunky because responses arrive faster than they are consumed. A better implementation (e.g., buffering or fixed-rate throttling) is needed to handle streaming more effectively.