-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve most skipped unittests #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HYLcool
commented
Jan 22, 2025
•
edited
Loading
edited
- unit test opt:
- open most skipped unit tests
- 20 unit tests for API-based OPs are all opened again by setting the API info with environment variables
- 1 unit test for video_motion_score_raft_filter is opened again by setting more appropriate thresholds to handle different model outputs on different hardware, which is normal.
- 7 unit tests for model-based OPs are opened again by decreasing the number of processors to avoid OOM of GPU memory.
- increase the shm_size to 128G to avoid implicit OOM issue with exit code 137 (ref)
- for now, there are still 9 unit tests that are skipped left to be resolved in future work
- 2 unit tests are skipped due to randomness from system resource utilization (adapter & monitor)
- 1 unit test is skipped due to an unsolved encoding problem (nlpcda_zh_mapper)
- 1 unit test is skipped due to OOM of GPU (video_captioning_from_summarizer_mapper, which requires more than 50GB mem)
- 5 unit tests are skipped due to an unsolved vllm error for distributed inference (similar to [Bug]: vllm.LLM does not seem to re-initialize for distributed inference with subsequent models with Offline Inference vllm-project/vllm#9727) (generate_*_mapper & optimize_*_mapper)
- open most skipped unit tests
- others:
- add default mem_required for some model-based OPs
- update sampling_params for vllm-based OPs due to vllm and transformers having similar inference parameters with different names.
- update device_map specification for latest diffusers library.
- fix some bugs & typos
…hod to move models to specified devices * fix unrecognized dtype: only need torch.dtype instead of strings like 'fp16' * open unittest for image_diffusion_mapper
…zation of meta and tags
# Conflicts: # configs/config_all.yaml # data_juicer/ops/aggregator/entity_attribute_aggregator.py # data_juicer/ops/aggregator/most_relavant_entities_aggregator.py # data_juicer/ops/aggregator/nested_aggregator.py # data_juicer/ops/mapper/video_captioning_from_summarizer_mapper.py # tests/ops/mapper/test_image_tagging_mapper.py
HYLcool
added
bug
Something isn't working
enhancement
New feature or request
dj:ci/cd
issues/PRs about CI/CD of Data-Juicer
environment
related to third-party dependency, DJ-pypi, DJ-docker, etc.
labels
Jan 22, 2025
yxdyc
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dj:ci/cd
issues/PRs about CI/CD of Data-Juicer
enhancement
New feature or request
environment
related to third-party dependency, DJ-pypi, DJ-docker, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.