Skip to content

정기현 9일차 과제 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

정기현 9일차 과제 #24

merged 2 commits into from
Jun 23, 2025

Conversation

electrohyun
Copy link
Collaborator

No description provided.

@electrohyun electrohyun requested a review from a team as a code owner June 20, 2025 01:28
@electrohyun electrohyun self-assigned this Jun 20, 2025
@@ -0,0 +1,34 @@
function pullDoll(board, column) {
for (let i = 0; i < board.length; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pullDoll 함수에서 반복문 대신 findIndex를 사용하면 코드가 더 간결하고 읽기 쉬워질 것 같습니다.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제에 맞춰 함수 이름 작명하였는데, 앞으로 프로그램 기능에 맞춰 작성하도록 하겠습니다! 리뷰 감사합니다.

Copy link
Collaborator

@sim16065 sim16065 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pullDoll 과 addToBucket 함수로 로직을 분리하신 점이 좋습니다! 수고 많으셨습니다~

@electrohyun
Copy link
Collaborator Author

감사합니다! 함수로 분리하는 것 계속 해보겠습니다😁

@electrohyun electrohyun merged commit 64a20fe into main Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants