This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Feature 3.4 #162
Open
Feature 3.4 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
faction23
commented
Jul 23, 2018
faction23
commented
- Added new custom icon field, with ability to group by categories, enable search, use ajax to handle very large sets if needed
- Added Numeric Input field, which handles steps, min and max and has an optional styled ui for +/-
- Added range slider field, which allows for single or multiple ranges in a slider type ui, along with optional synchronized numeric input when in single mode
- Added toggle field, which can either be a single checkbox and simply returns true/false, or can have a stylized ui enabled
- Added column width field to have a stylized ui for selecting widths against a grid you set.
- Added tab group field to allow you to created tabbed ui's
- Added style family select field, a field that synchronizes with site builder to allow you to apply style families that are created in that app to a panel.
- Enhanced TextArea to have an optional draftjs editor as well, in case you dont want to use TinyMCE. allows for easy customization of what features are supplied, if you say want a trimmed down editor.
- Updated all UI to new designs
- Added compact modes to most fields, allowing you to create tighter ui's as you see fit
- Added tooltip lib to have descriptions in tooltips, to further compress UI
- Added in options for radio, checkbox, image select to allow you control how many display per row, on a 12 col grid.
- Allowed you to create compact inline groups with the group fields new compact mode
- Updated to React 16 and updated all code to match current standards
- Updated tests and added snapshot tests for all field tests
- Enabled infinite nesting of child panels with recursive function, indexMap
- Added new event emitters into iframe for child panel events, enhanced repeater events
- Implemented custom autosave endpoint to allow for much higher data size, as WP uses form encoded which cant handle very large panel data payloads
- Broke up documentation into directories and partials as it was getting unwieldy, and enhanced
- Added modal for save confirm when you exit live preview
- Nested conditional classes have been added
- Close other accordions at that level when opening one
- Implemented panel permissions system
- Many bugfixes.
# Conflicts: # ui/dist/master.css # ui/dist/master.js # ui/dist/master.js.map
(cherry picked from commit 97b47f9) # Conflicts: # ui/dist/master.css
… heartbeats dont collide
…ture/3.4/new-fields
jbrinley
suggested changes
Dec 14, 2018
ModularContent/Fields/Checkbox.php
Outdated
|
|
||
| protected $default = []; | ||
| protected $layout = 'vertical'; | ||
| protected $option_width = 12; |
There was a problem hiding this comment.
This could still use an inline comment.
| $blueprint[ 'default' ] = (object) $this->default; | ||
| $blueprint = parent::get_blueprint(); | ||
| $blueprint['default'] = (object) $this->default; | ||
| $blueprint['layout'] = $this->layout; |
There was a problem hiding this comment.
@faction23 : any comment here? I see layout on 15 out of 25 field types. Can we set a "default" layout for the other 10, and consolidate this logic into the parent class? Field can have a property $valid_layouts and the method validate_layout(). Child classes can extend by overriding $valid_layouts.
Update tribe-panel-builder.php
|
We've been using 3.4 in most projects correct? Any reason this is not merged? |
There are outstanding issues yet to be addressed due to time constraints. I have still generally not recommended using 3.4 on projects; it is not stable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.