This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Convert toggle arrows to <button> and make them accessible #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Rachel! |
|
@ryanurban Hey Ryan! No problem. The only area I really wasn't sure about was how y'all recommend adding/handling i18n for the aria labels. |
faction23
reviewed
Jan 14, 2021
| const expanded = this.state.active ? 'true' : 'false'; | ||
|
|
||
| const escapedLabel = this.props.label.replace(/"/g, '\\\\\"'); | ||
| const buttonLabel = `${this.state.active ? 'Collapse' : 'Expand'} ${escapedLabel}`; |
There was a problem hiding this comment.
Probably want to make these strings translatable?
There was a problem hiding this comment.
I agree but, per my previous comment, I don't know how y'alls setup handles translation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to make all of the arrow "toggle" buttons to be
<button>s and make expanding/collapsing panels, groups, accordions, and repeater fields accessible to those who cannot use a mouse.