Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being explicit in Meta_Map #79

Open
wants to merge 7 commits into
base: 4.x
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

  • set properties in constructor
  • put errors in conditionals (in get_value)

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Mar 7, 2023

🟢 Happy and unhappy path

if (error) unhappy path;

happy path;

Source


@defunctl This is an old one.
How about a merge?
... it turns out there is another 3 year old: #78

Copy link
Collaborator

@defunctl defunctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya,

Sorry for the long wait! This should be branched from the 4.x default branch, if you want to close this and open a new PR with the requested changes, I can get it in the next release.

@defunctl defunctl changed the base branch from master to 4.x March 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants