Enable to touch in Android native browser and Chrome #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable to touch in Android native browser and Chrome Fix flashing display when touches are started in Android native browser
| // mark these touches so they aren't used as taps/holds | ||
| l0.wasPinch = true; | ||
| l1.wasPinch = true; | ||
|
|
||
| // scale about the center of these touches | ||
| var center = MM.Point.interpolate(p0, p1, 0.5); | ||
| var center = MM.Point.interpolate(p0, p1, 0.5); | ||
| var scale = Math.sqrt(Math.pow(p0.x - p1.x, 2) + Math.pow(p0.y - p1.y, 2)); |
There was a problem hiding this comment.
Can this use MM.Point.dist instead? https://github.com/modestmaps/modestmaps-js/blob/master/src/point.js#L18
There was a problem hiding this comment.
Sure.
Sorry I didn't know clearly about that function, so will check it and change to use it.
There was a problem hiding this comment.
Sorry, I add all comments not by our group account but my own account.
Conflicts: modestmaps.js modestmaps.min.js src/touch.js src/utils.js
|
I committed new source. |
|
Still not really supporting the addition of insertCss etc for removing touchcallouts. MM should not mess with the stylesheet API or add rules like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable to touch in Android native browser and Chrome.
And fix flashing display when touches are started in Android native browser.