Feature-Request: Radio-Button Settings #202
Comments
This was referenced Feb 27, 2023
Open
opengeek
added a commit
to modxcms/revolution
that referenced
this issue
Mar 22, 2024
### What does it do? This makes sure the JS doesn't throw an error in the case that the items-object is an array, just like in #16404 for 3.x ### Why is it needed? When using ExtJS to create components of the xtype: 'radiogroup' to be used in CMPs inside a form, this function gets called and tries to iterate over it's items array with a method that doesn't exist. This PR isn't changing the way forms or the clearDirty-method are handled, it just assures no error is thrown when using radiogroup-components. ### Related issue(s)/PR(s) Resolves modmore/ClientConfig#202 Resolves modmore/ClientConfig#176 Resolves modmore/ClientConfig#143 --------- Co-authored-by: Jason Coward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to be able to use radio-inputs for some settings.
In my opinion that would be useful for little "switch-settings" like for example "enable/disable custom scrollbar".
Also, as currently I am using dropdowns for these two options, this would save the user 1 click :-)
As Mark attempted in #176 with the multi-select checkboxes, I also ran into the same JS-issue.
Jako also stumbled upon the exact same issue modxcms/revolution#12177 some time ago.
I will prepare a PR for my own feature-request here, and I am attempting a PR on the actual issue in the MODX code.
The text was updated successfully, but these errors were encountered: