Radio settings #203
Open
Radio settings #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new radiogroup combo
|
Sneak-Preview:
How it would be used:
|
|
This is cool. As far as that core fix goes, do we have to implement some kind of version check to prevent radiogroups from being used on <3.0.4? |
|
Probably a good idea! And also we should do the same for the 2.x branch, when modxcms/revolution#16467 is accepted. That version-check would need to go into this if-clause: Correct? Do you know, if we have the MODX-version information there available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for radiogroup-settings. See #202 for details.
Resolves #202
But needs to wait for modxcms/revolution#16404 to be accepted.