Skip to content

Commit

Permalink
Fix app builds not launching (#3035)
Browse files Browse the repository at this point in the history
* Fix app builds not launching

* Revert tauri version change
  • Loading branch information
Geometrically authored Dec 18, 2024
1 parent b7f514c commit c1b1e67
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 112 deletions.
128 changes: 26 additions & 102 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ strip = true # Remove debug symbols
[profile.dev.package.sqlx-macros]
opt-level = 3

[patch.crates-io]
tauri = { git = "https://github.com/modrinth/tauri", rev = "9c36dd3" }
# [patch.crates-io]
# tauri = { git = "https://github.com/modrinth/tauri", rev = "67911d5" }
2 changes: 1 addition & 1 deletion apps/app-frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@modrinth/app-frontend",
"private": true,
"version": "0.9.0",
"version": "0.9.0-1",
"type": "module",
"scripts": {
"dev": "vite",
Expand Down
5 changes: 3 additions & 2 deletions apps/app/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "theseus_gui"
version = "0.9.0"
version = "0.9.0-1"
description = "The Modrinth App is a desktop application for managing your Minecraft mods"
license = "GPL-3.0-only"
repository = "https://github.com/modrinth/code/apps/app/"
Expand All @@ -17,7 +17,8 @@ serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
serde_with = "3.0.0"

tauri = { git = "https://github.com/modrinth/tauri", rev = "9c36dd3", features = ["devtools", "macos-private-api", "protocol-asset", "unstable"] }
tauri = { version = "2.1.1", features = ["devtools", "macos-private-api", "protocol-asset", "unstable"] }
# tauri = { git = "https://github.com/modrinth/tauri", rev = "67911d5", features = ["devtools", "macos-private-api", "protocol-asset", "unstable"] }
tauri-plugin-window-state = "2.2.0"
tauri-plugin-deep-link = "2.2.0"
tauri-plugin-os = "2.2.0"
Expand Down
3 changes: 2 additions & 1 deletion apps/app/src/api/ads.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ pub async fn init_ads_window<R: Runtime>(
AD_LINK.parse().unwrap(),
),
)
.initialization_script_for_main_only(LINK_SCRIPT, false)
.initialization_script(LINK_SCRIPT)
// .initialization_script_for_main_only(LINK_SCRIPT, false)
.user_agent("Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36")
.zoom_hotkeys_enabled(false)
.transparent(true),
Expand Down
2 changes: 1 addition & 1 deletion apps/app/tauri.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
]
},
"productName": "Modrinth App",
"version": "0.8.9",
"version": "0.9.0-1",
"mainBinaryName": "Modrinth App",
"identifier": "ModrinthApp",
"plugins": {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-lib/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "theseus"
version = "0.9.0"
version = "0.9.0-1"
authors = ["Jai A <[email protected]>"]
edition = "2021"

Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/components/content/ContentListPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ function setSelected(value: boolean) {
</div>
<div class="bg-bg-raised rounded-xl">
<VirtualScroller :items="items" :default-size="64" style="height: 100%">
<template #item="{ ref }">
<template #item="{ ref, index }">

Check warning on line 82 in packages/ui/src/components/content/ContentListPanel.vue

View workflow job for this annotation

GitHub Actions / Build, Test, and Lint

Variable 'ref' is already declared in the upper scope
<ContentListItem
v-model="selectionStates[ref.filename]"
:item="ref"
:last="ref === items.length - 1"
:last="index === items.length - 1"
class="mb-2"
@update:model-value="updateSelection"
>
Expand Down

0 comments on commit c1b1e67

Please sign in to comment.