Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(knossos): Rewrite date range system on analytics dashboard. #1301

Merged
merged 19 commits into from
Jan 29, 2025
Merged

refactor(knossos): Rewrite date range system on analytics dashboard. #1301

merged 19 commits into from
Jan 29, 2025

Conversation

IMB11
Copy link
Contributor

@IMB11 IMB11 commented Jul 17, 2024 •
edited
Loading

Goals:

  • Use clearer format/types that allows for further expansion in the future.
  • Migrate fully to dayjs instead of haphazardly converting between Date and dayjs.DayJs types continuously.
  • Remember chosen range in localStorage.
  • Fix issue with drop-offs on the edge of ranges.

IMB11
IMB11 commented Jul 17, 2024
View reviewed changes
apps/frontend/nuxt.config.ts Outdated Show resolved Hide resolved
@IMB11
Copy link
Contributor Author

IMB11 commented Jul 18, 2024

This is ready, decided to just keep it as a dropdown - someone else with better experience can refactor the UX, right now, the backend is much cleaner and should make this easier to do.

@IMB11 IMB11 changed the title Refactor date range system on analytics dashboard. refactor(knossos): Rewrite date range system on analytics dashboard. Jul 19, 2024
@IMB11 IMB11 requested a review from brawaru July 19, 2024 15:13
@IMB11
Copy link
Contributor Author

IMB11 commented Jul 19, 2024

Awaiting eslint fixes before continuing.

@IMB11
Copy link
Contributor Author

IMB11 commented Jul 28, 2024

image

Should be good now the lint fix PR is merged.

@Erb3 Erb3 mentioned this pull request Aug 13, 2024
Open
@IMB11
Copy link
Contributor Author

IMB11 commented Dec 28, 2024

Any updates on this?

@Prospector
Copy link
Member

LGTM! Sorry for the late review

@Prospector Prospector added this pull request to the merge queue Jan 29, 2025
Merged via the queue into modrinth:main with commit b195536 Jan 29, 2025
1 check passed
@IMB11
Copy link
Contributor Author

IMB11 commented Jan 30, 2025 •
edited
Loading

No worries! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prospector Prospector Prospector approved these changes

@brawaru brawaru Awaiting requested review from brawaru

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IMB11 @Prospector @brawaru