Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping updater at runtime with an environmental variable #2388

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Chicken
Copy link
Contributor

@Chicken Chicken commented Sep 10, 2024

Setting the environmental variable MODRINTH_EXTERNAL_UPDATE_PROVIDER to anything, such as 1 will skip the updater.
Especially useful for 3rd party linux distributions where updating is handled by a package manager.

@Chicken Chicken force-pushed the feat/skip-updater-at-runtime branch from e042f5a to a26ea7d Compare September 10, 2024 17:34
@Chicken Chicken force-pushed the feat/skip-updater-at-runtime branch from a26ea7d to 21bef69 Compare October 2, 2024 20:23
@Chicken Chicken force-pushed the feat/skip-updater-at-runtime branch from 21bef69 to 30e8350 Compare October 31, 2024 14:19
@Chicken Chicken force-pushed the feat/skip-updater-at-runtime branch from bf025ef to 4353801 Compare December 24, 2024 13:13
@Chicken
Copy link
Contributor Author

Chicken commented Dec 24, 2024

Hey, I've yet again rebased the PR for main. This has already been approved once. We have already gotten three releases without this included. Any updated on if and when we could get this merged?

@wackywobblewave
Copy link

wackywobblewave commented Dec 26, 2024

i would like to give some context based on the conversation on discord. i myself have had to explain to at least 15 people why the flatpak doesn't work and how to install the test build of the flatpak bot. this is a workaround that shouldn't be necessary, the flatpak should be able to work completely independently of the auto updater.

the biggest concern i've seen why this hasn't been merged yet is that people shouldn't use outdated versions of modrinth and that this would drive people to do so. i disagree, the name itself says “external update provider”, i don't think people will use it to skip updates, and if they want to do that they would find other ways. the whole thing is just to make sure that the flatpak works while the flathub bot is working, the PR is getting merged, and while the flatpak is checked by the flathub team. The same applies to the other third party packages.

also i have seen that a cli argument was suggested as an alternative, i think this is a worse idea because it would be harder to implement, i like to quote getchoo on this: https://discord.com/channels/734077874708938864/734077874708938867/1321650292214726768

@Geometrically Geometrically merged commit 021fee6 into modrinth:main Jan 9, 2025
@Erb3 Erb3 mentioned this pull request Jan 10, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants