-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Add filter query and download hash to the url during download modal use #3138
Merged
Prospector
merged 12 commits into
modrinth:main
from
Awakened-Redstone:add-queries-to-show-download-modal
Jan 10, 2025
Merged
feat(frontend): Add filter query and download hash to the url during download modal use #3138
Prospector
merged 12 commits into
modrinth:main
from
Awakened-Redstone:add-queries-to-show-download-modal
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendent of the modal
…, and fix linting issues
# Conflicts: # apps/frontend/src/pages/[type]/[id].vue
Awakened-Redstone
changed the title
feat(frontend): Add filter query and download hash to the url during donwload modal use
feat(frontend): Add filter query and download hash to the url during download modal use
Jan 10, 2025
nice! thanks :D |
Prospector
requested changes
Jan 10, 2025
My computer does not like running the app, making testing a lot harder, so I'll undo this change, at least for now
Prospector
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Signed-off-by: Prospector <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #3133, adding a feature that will update the URL on the browser to contain the query filters and the download modal hash added by the PR