feat(frontend): Store last selected game version and platform for download modal #3284
+19
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores selected game version and platform(modloader) in localStorage to retrive them when download modal openned
2 tasks
denisJaved
changed the title
Signed-off-by: Denis <[email protected]>
denisJaved
force-pushed
the
remember-game-version-and-platform
branch
from
30a24fb to
9fdac5a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the download modal by persisting the last user-selected game version and platform using localStorage. Key changes include:
- Replacing ButtonStyled blocks with Accordions for game version and platform selection.
- Introducing helper functions (setSelectedGameVersion and setSelectedPlatform) to update both reactive refs and localStorage.
- Loading persisted selections on the client when the page is loaded.
Comments suppressed due to low confidence (2)
apps/frontend/src/pages/[type]/[id].vue:328
- Confirm that changing this condition from v-else-if to v-if does not inadvertently render the platform Accordion for resourcepack projects, potentially affecting the intended download flow.
v-if="project.project_type !== 'resourcepack'"
apps/frontend/src/pages/[type]/[id].vue:880
- [nitpick] Ensure that using localStorage with the keys 'selected_game_version' and 'selected_platform' is consistent with the application standards, and consider any necessary type handling for stored values.
if (import.meta.client) {
| @@ -1009,7 +979,18 @@ const licenseIdDisplay = computed(() => { | |||
| return id; | |||
| } | |||
| }); | |||
|
|
|||
| function setSelectedGameVersion(version) { | |||
There was a problem hiding this comment.
[nitpick] Consider adding inline documentation for the new setSelectedGameVersion and setSelectedPlatform functions to clarify their role in persisting user selections.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores last user selected game version and platform (aka modloader) to retrive them before openning download modal.
Resolves #2332
PS: It's my first contribution to modrinth. I'm sorry if i did smth wrong