This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
side types overhaul #567
thesuzerainAnnotations
6 warnings
|
security_audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/routes/v2/version_creation.rs#L209
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/routes/v2/version_creation.rs:209:74
|
209 | let example_version = match version_item::Version::get(vid, &**pool, &redis).await? {
| ^^^^^^ help: change this to: `redis`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/routes/v2/version_creation.rs#L204
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/routes/v2/version_creation.rs:204:79
|
204 | let vid = match project_item::Project::get_id(project_id.into(), &**pool, &redis).await?.and_then(|p| p.versions.get(0).cloned()) {
| ^^^^^^ help: change this to: `redis`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `Option<LegacySideType>` which implements the `Copy` trait:
src/routes/v2/projects.rs#L348
warning: using `clone` on type `Option<LegacySideType>` which implements the `Copy` trait
--> src/routes/v2/projects.rs:348:23
|
348 | let server_side = v2_new_project.server_side.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v2_new_project.server_side`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `Option<LegacySideType>` which implements the `Copy` trait:
src/routes/v2/projects.rs#L347
warning: using `clone` on type `Option<LegacySideType>` which implements the `Copy` trait
--> src/routes/v2/projects.rs:347:23
|
347 | let client_side = v2_new_project.client_side.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v2_new_project.client_side`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
useless conversion to the same type: `std::iter::Flatten<std::collections::hash_map::IntoValues<database::models::ids::LoaderId, std::vec::Vec<database::models::loader_fields::LoaderField>>>`:
src/database/models/loader_fields.rs#L323
warning: useless conversion to the same type: `std::iter::Flatten<std::collections::hash_map::IntoValues<database::models::ids::LoaderId, std::vec::Vec<database::models::loader_fields::LoaderField>>>`
--> src/database/models/loader_fields.rs:323:22
|
323 | let result = found_loader_fields
| ______________________^
324 | | .into_values()
325 | | .flatten()
326 | | .into_iter()
| |________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
|
323 ~ let result = found_loader_fields
324 + .into_values()
325 + .flatten()
|
|