Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Fix new charge date, pyro suspend reason #3688

Fix new charge date, pyro suspend reason

Fix new charge date, pyro suspend reason #3688

GitHub Actions / clippy succeeded Oct 14, 2024 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 293 in src/routes/internal/billing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/routes/internal/billing.rs:293:83
    |
293 |                 let payment_method_id = if let Ok(id) = PaymentMethodId::from_str(&payment_method) {
    |                                                                                   ^^^^^^^^^^^^^^^ help: change this to: `payment_method`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 72 in src/queue/analytics.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
   --> src/queue/analytics.rs:67:5
    |
67  | /     pub async fn index(
68  | |         &self,
69  | |         client: clickhouse::Client,
70  | |         redis: &RedisPool,
71  | |         pool: &PgPool,
72  | |     ) -> Result<(), ApiError> {
    | |_____________________________^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
    = help: specify the types explicitly
note: in edition 2024, the requirement `!: redis::FromRedisValue` will fail
   --> src/queue/analytics.rs:143:18
    |
143 |             pipe.query_async(&mut *redis)
    |                  ^^^^^^^^^^^

Check warning on line 507 in src/database/redis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
   --> src/database/redis.rs:504:5
    |
504 | /     pub async fn delete_many(
505 | |         &mut self,
506 | |         iter: impl IntoIterator<Item = (&str, Option<String>)>,
507 | |     ) -> Result<(), DatabaseError> {
    | |__________________________________^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
    = help: specify the types explicitly
note: in edition 2024, the requirement `!: redis::FromRedisValue` will fail
   --> src/database/redis.rs:521:13
    |
521 |             redis_execute(&mut cmd, &mut self.connection).await?;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 493 in src/database/redis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
   --> src/database/redis.rs:491:5
    |
491 | /     pub async fn delete<T1>(&mut self, namespace: &str, id: T1) -> Result<(), DatabaseError>
492 | |     where
493 | |         T1: Display,
    | |____________________^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
    = help: specify the types explicitly
note: in edition 2024, the requirement `!: redis::FromRedisValue` will fail
   --> src/database/redis.rs:500:9
    |
500 |         redis_execute(&mut cmd, &mut self.connection).await?;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 427 in src/database/redis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
   --> src/database/redis.rs:421:5
    |
421 | /     pub async fn set(
422 | |         &mut self,
423 | |         namespace: &str,
424 | |         id: &str,
425 | |         data: &str,
426 | |         expiry: Option<i64>,
427 | |     ) -> Result<(), DatabaseError> {
    | |__________________________________^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
    = help: specify the types explicitly
note: in edition 2024, the requirement `!: redis::FromRedisValue` will fail
   --> src/database/redis.rs:439:9
    |
439 |         redis_execute(&mut cmd, &mut self.connection).await?;
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 147 in src/database/redis.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
   --> src/database/redis.rs:133:5
    |
133 | /     pub async fn get_cached_keys_raw_with_slug<F, Fut, T, I, K, S>(
134 | |         &self,
135 | |         namespace: &str,
136 | |         slug_namespace: Option<&str>,
...   |
146 | |         K: Display + Hash + Eq + PartialEq + Clone + DeserializeOwned + Serialize,
147 | |         S: Display + Clone + DeserializeOwned + Serialize + Debug,
    | |__________________________________________________________________^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
    = help: specify the types explicitly
note: in edition 2024, the requirement `!: redis::FromRedisValue` will fail
   --> src/database/redis.rs:366:22
    |
366 |                 pipe.query_async(&mut connection).await?;
    |                      ^^^^^^^^^^^
    = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default