This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Fix declaration types for icons #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-export icons using consts to help TypeScript resolve proper types for icon files since we cannot really declare export types for files with custom extensions and parameters (`.svg?component`) in declarations.
brawaru
force-pushed
the
fix/svg-exports-types
branch
from
21dd061 to
d06f316
Compare
triphora
approved these changes
Nov 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export icons using consts to help TypeScript resolve proper types for
icon files since we cannot really declare export types for files with
custom extensions and parameters (
.svg?component) in declarations.