Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant error logs #16

Open
joshuahannan opened this issue Apr 25, 2018 · 1 comment
Open

Redundant error logs #16

joshuahannan opened this issue Apr 25, 2018 · 1 comment

Comments

@joshuahannan
Copy link

The wallet reverts when non-owners try to perform illegal operations on it. When owners try to perform illegal operations, or operations that cannot be performed for some reason, the wallet does not revert and instead returns false, emitting one or more error events describing the nature of the error in question.
WalletMainLib, in particular, emits two errors when an owner operation fails: LogErrorMsg and LogTransactionFailed. These two errors are always emitted as a pair, and doing so may be not only redundant, but could actually make it harder to find error information in the blockchain when the need arises.
Consider merging LogErrorMsg and LogTransactionFailed into a single event.

@joshuahannan
Copy link
Author

I'm tempted to not fix this one because we want to keep LogErrorMsg consistent across all our libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant