You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The wallet reverts when non-owners try to perform illegal operations on it. When owners try to perform illegal operations, or operations that cannot be performed for some reason, the wallet does not revert and instead returns false, emitting one or more error events describing the nature of the error in question.
WalletMainLib, in particular, emits two errors when an owner operation fails: LogErrorMsg and LogTransactionFailed. These two errors are always emitted as a pair, and doing so may be not only redundant, but could actually make it harder to find error information in the blockchain when the need arises.
Consider merging LogErrorMsg and LogTransactionFailed into a single event.
The text was updated successfully, but these errors were encountered:
The wallet reverts when non-owners try to perform illegal operations on it. When owners try to perform illegal operations, or operations that cannot be performed for some reason, the wallet does not revert and instead returns false, emitting one or more error events describing the nature of the error in question.
WalletMainLib, in particular, emits two errors when an owner operation fails: LogErrorMsg and LogTransactionFailed. These two errors are always emitted as a pair, and doing so may be not only redundant, but could actually make it harder to find error information in the blockchain when the need arises.
Consider merging LogErrorMsg and LogTransactionFailed into a single event.
The text was updated successfully, but these errors were encountered: