Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent requirement for requiredMajor #20

Open
joshuahannan opened this issue Apr 25, 2018 · 0 comments
Open

Inconsistent requirement for requiredMajor #20

joshuahannan opened this issue Apr 25, 2018 · 0 comments

Comments

@joshuahannan
Copy link

In WalletAdminLib's checkRequiredChange function, a check is performed to ensure the number of required signatures in a major transaction is at least two less than the number of owners. However, this is never enforced in WalletMainLib's init function, which only requires _requiredMajor to be smaller or equal than the number of owners.
Consider abstracting these requirements into a common function, so as to have consistent behavior in initialization and updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant