[stdlib] rename variance parameter to std (standard deviation)
#4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move this test to a separate function (for this is a borderline quality test) and use |
soraros
reviewed
Mar 6, 2025
soraros
reviewed
Mar 6, 2025
soraros
reviewed
Mar 6, 2025
…y distributed random values Signed-off-by: Illia Sheshyn <[email protected]>
Signed-off-by: Illia Sheshyn <[email protected]>
illiasheshyn
force-pushed
the
update-random-normal-arg-variance-name
branch
from
b76ccc1 to
c3c6e5c
Compare
|
@soraros thanks for the quick review! Do the changes align with what you had in mind? |
martinvuyk
reviewed
Mar 7, 2025
| return external_call["KGEN_CompilerRT_NormalDouble", Float64]( | ||
| mean, variance | ||
| ) | ||
| return external_call["KGEN_CompilerRT_NormalDouble", Float64](mean, std) |
There was a problem hiding this comment.
Uhm, can you really just change that? if the underlying function expects a variance and you give it a standard deviation... you'll get another distribution than what you're expecting. You'd have to square the value for this to make sense.
There was a problem hiding this comment.
I thought the bug was that the underlying function expects a std, and the argument was wrongly named?
There was a problem hiding this comment.
My bad, didn't read the linked issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the following issue regarding the argument name in
randn_float64()as well asrandn.The choice to go with standard deviation over variance was made based on the existing
random.gaussfunction from Python's standard library and numpy'srandom.normalwhich both take mean and standard deviation.Things to consider
Changes
randn_float64()andrandn