Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Add Pointer(to=) constructors #3606

Draft
wants to merge 6 commits into
base: nightly
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

Add Pointer(to=) constructors

@martinvuyk martinvuyk requested a review from a team as a code owner October 4, 2024 18:54
Signed-off-by: martinvuyk <[email protected]>
Comment on lines 314 to 324
# FIXME
# @always_inline("nodebug")
# fn __init__(
# inout self, *, ref [lifetime, address_space._value.value]to: type
# ):
# """Create a pointer with the input value.

# Args:
# to: The value to construct a pointer to.
# """
# self = Self(_mlir_value=__get_mvalue_as_litref(to))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be in conflict with @value, I think we should file an issue.

@JoeLoser JoeLoser added the blocked Blocked by another issue that must be resolved first label Nov 5, 2024
@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 5, 2024

Blocked by #3617. @VerdagonModular or @lattner - you may be interested in this sort of thing.

@martinvuyk martinvuyk marked this pull request as draft November 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue that must be resolved first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants