-
-
Notifications
You must be signed in to change notification settings - Fork 314
fix(nextjs-mf): Try CSP-safe method for getting globalThis
first
#3776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(nextjs-mf): Try CSP-safe method for getting globalThis
first
#3776
Conversation
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
globalThis
firstglobalThis
first
@mitchellrj run pnpm changeset add |
@mitchellrj bump |
@ScriptedAlchemy want me to bring up to date with |
bbe342e
to
05ff51b
Compare
There's still an issue with the type of |
a8f9efa
to
a61b4bd
Compare
a61b4bd
to
ee0a638
Compare
Okay does latest PR seem to work? address previous comments? |
Description
Where
unsafe-eval
is not permitted in a Content Security Policy, trying theFunction
approach first then falling back causes unnecessary CSP Reports and errors to be logged by the browser. This approach usesglobalThis
by default, then attempts to catch the Webpack rewriting of it.Related Issue
#3772
Types of changes
Checklist