feat: implement rslib with TypeScript declaration generation #3883

ScriptedAlchemy · 2025-07-03T20:57:44Z

Summary

Implement rslib configuration with TypeScript declaration file generation
Add missing entry points (helpers, core, global) to rslib config
Update runtime-core package.json exports to use generated declarations
Fix import patterns in runtime package to use namespace imports
Exclude dist directories from TypeScript compilation to prevent conflicts

Key Changes

✅ Runtime-core builds successfully with .d.ts generation via rslib
✅ Both pnpm build and nx run runtime-core:build work correctly
✅ Added global variable definitions for build-time replacement
✅ Updated package exports to point to generated declaration files
✅ Most workspace packages now build successfully

Test plan

Runtime-core builds with rslib and generates TypeScript declarations
Runtime package builds successfully with corrected imports
Workspace build shows significant improvement in package success rate
Both rslib executor and direct pnpm scripts work correctly

🤖 Generated with Claude Code

- Configure rslib to generate TypeScript declaration files (.d.ts) - Add missing entry points (helpers, core, global) to rslib config - Update runtime-core package.json exports to use generated declarations - Fix import patterns in runtime package to use namespace imports - Exclude dist directories from TypeScript compilation to prevent conflicts - Add global variable definitions for build-time replacement - Update multiple package tsconfigs to prevent dual type resolution This enables proper TypeScript declaration generation via rslib while maintaining compatibility with existing build processes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

changeset-bot · 2025-07-03T20:57:48Z

⚠️ No Changeset found

Latest commit: 232c673

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2025-07-03T20:57:49Z

✅ Deploy Preview for module-federation-docs ready!

Name	Link
🔨 Latest commit	`232c673`
🔍 Latest deploy log	https://app.netlify.com/projects/module-federation-docs/deploys/688028f27cd8b70008bec885
😎 Deploy Preview	https://deploy-preview-3883--module-federation-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

tools/rslib-plugin/src/executors/build/executor.ts

The tools/scripts/publish.mjs file was not referenced anywhere in the codebase and appears to be legacy/template code that was never integrated into the actual publishing workflow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Replace @nx/rollup executor with rslib for runtime-core package - Add @rslib/core as devDependency and create rslib.config.ts - Update package.json exports to match rslib output format (.js/.cjs) - Add TypeScript declaration generation with proper env.d.ts - Update tsconfig.lib.json for correct output paths - Remove duplicate global.d.ts file - Add build script to package.json for direct rslib execution This migration enables better TypeScript declaration generation and aligns with modern build tooling standards. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Move global declarations from src/global.ts to separate global-types.d.ts - This prevents conflicts between source and generated .d.ts files - Resolves TypeScript errors where packages saw both src and dist types - Enhanced package now builds successfully without type conflicts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Configure project.json to use ../../tools/rslib-plugin:build executor - Fix rslib.config.ts import to use JSON import instead of fs.readFileSync - Add @rslib/core devDependency to package.json - Ensure proper rslib configuration for TypeScript declaration generation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

@nx

- Updated @nx dependencies from 21.0.3 to 21.2.3 in package.json - Updated runtime-core package.json version and export paths - Kept @rslib/core at 0.10.4 in apps/rslib-module - Fixed export type conflicts in runtime-core/src/index.ts - Regenerated pnpm-lock.yaml 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add proper global type declarations in runtime/global.d.ts for Federation interfaces - Fix implicit any type errors in runtime/src/utils.ts by adding proper typing - Import Federation and RemoteEntryExports types from runtime-core - Remove type casting in favor of proper TypeScript declarations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Fix rslib bundling configuration in runtime-core (bundle: true) - Add global type declarations for Federation interfaces - Fix TypeScript implicit any type errors in runtime-core - Correct package.json export conditions ordering in chrome-devtools - Add global.d.ts files to bridge packages for type safety 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Replace exec() calls with direct rslib build API - Use rslib's loadConfig function for TypeScript config loading - Improve reliability and performance in CI environments - Fix package.json exports to match actual rslib output files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add support for external dependencies with glob patterns - Support multiple output formats (esm, cjs, umd, iife) - Add additional entry points support - Implement proper TypeScript declaration generation - Add comprehensive test suite for rslib executor - Fix path resolution for Nx workspace conventions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

ScriptedAlchemy

tools/rslib-plugin/src/executors/build/executor.ts

+    for (const ext of options.external) {
+      if (ext.includes('*')) {
+        // Handle glob patterns like "@module-federation/*"
+        const pattern = ext.replace('*', '(.*)');


To fix the issue, the replace method should be updated to use a regular expression with the global flag (g) to ensure that all occurrences of * in the ext string are replaced. This change will make the code handle cases where ext contains multiple * characters correctly.

The replacement involves modifying the ext.replace('*', '(.*)') call to use a regular expression: ext.replace(/\*/g, '(.*)'). This ensures that every * in the string is replaced with (.*).

…ping or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

ScriptedAlchemy and others added 7 commits May 16, 2025 01:24

feat: rslib executor

d374fac

Changes from background composer bc-20d504d2-2fd1-4b53-88c1-eeb10cd15ecc

4ee006b

Changes from background composer bc-20d504d2-2fd1-4b53-88c1-eeb10cd15ecc

80ee7ad

Changes from background composer bc-20d504d2-2fd1-4b53-88c1-eeb10cd15ecc

63f5b56

Changes from background composer bc-20d504d2-2fd1-4b53-88c1-eeb10cd15ecc

e9e43e8

Changes from background composer bc-20d504d2-2fd1-4b53-88c1-eeb10cd15ecc

03eb124

github-actions bot added the change: feat label Jul 3, 2025

github-advanced-security bot found potential problems Jul 3, 2025

View reviewed changes

tools/rslib-plugin/src/executors/build/executor.ts Fixed Show fixed Hide fixed

ScriptedAlchemy and others added 16 commits July 3, 2025 14:03

chore: implement partial next version detection

f5ce542

fix: update pnpm-lock.yaml to include @rslib/core dependency

db38602

fix: correct runtime-core exports and add bridge-react global types

b6a51df

chore: reverse chaneg to rslib module

07d31f8

chore: update pnpm lockfile

bbb2f26

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

chore: executor

184e0cf

chore: update pnpm lockfile and build rslib plugin

bab6691

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

github-advanced-security bot found potential problems Jul 22, 2025

View reviewed changes

Potential fix for code scanning alert no. 134: Incomplete string esca…

232c673

…ping or encoding Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

ScriptedAlchemy merged commit 0b0c5da into main Jul 23, 2025
7 of 8 checks passed

ScriptedAlchemy deleted the cursor/create-rslib-executor-for-nx-3342 branch July 23, 2025 00:12

2heal1 mentioned this pull request Jul 24, 2025

release v0.17.1 #3950

Merged

@@ -145,3 +145,3 @@
                     // Handle glob patterns like "@module-federation/*"
-                    const pattern = ext.replace('*', '(.*)');
+                    const pattern = ext.replace(/\*/g, '(.*)');
                     externals[pattern] = ext;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: implement rslib with TypeScript declaration generation #3883

feat: implement rslib with TypeScript declaration generation #3883

Uh oh!

ScriptedAlchemy commented Jul 3, 2025

Uh oh!

changeset-bot bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Uh oh!

Uh oh!

feat: implement rslib with TypeScript declaration generation #3883

feat: implement rslib with TypeScript declaration generation #3883

Uh oh!

Conversation

ScriptedAlchemy commented Jul 3, 2025

Summary

Key Changes

Test plan

Uh oh!

changeset-bot bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for module-federation-docs ready!

Uh oh!

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Uh oh!

changeset-bot bot commented Jul 3, 2025 •

edited

Loading

netlify bot commented Jul 3, 2025 •

edited

Loading